Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump rustls-webpki from 0.102.8 to 0.103.0 #3650

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 25, 2025

Bumps rustls-webpki from 0.102.8 to 0.103.0.

Release notes

Sourced from rustls-webpki's releases.

0.103.0

  • Breaking change: add context to name validation errors. This adds a value to the CertNotValidForName error variant.
  • Breaking change: stop Error being Copy -- the above change required this, as it started to have an allocated field.
  • Breaking change: add context to time-based errors. This adds fields to the CertNotValidYet, CertExpired, and CrlExpired error variants.
  • Breaking change: use algorithm identifiers from rustls-pki-types. This removes the alg_id module from this crate's public interface.
  • Breaking change: remove reexport of rustls-pki-types.
  • Breaking change: remove provider features from default feature set, and rename aws_lc_rs feature to aws-lc-rs.

What's Changed

Full Changelog: rustls/webpki@v/0.102.8...v/0.103.0

Commits
  • 5c72344 Include ignored tests in coverage measurement
  • d800833 Run all tests in CI
  • 9da0b63 build(deps): bump cryptography from 44.0.0 to 44.0.1
  • 84b1463 rustfmt: style_edition 2024
  • 59f69f3 build(deps): bump seanmiddleditch/gha-setup-ninja from 5 to 6
  • a182fb0 Add context to CrlExpired errors
  • 3f08209 Test for cert time validity
  • dee8d0a Add context to CertExpired errors
  • 1c770af Add context to CertNotValidYet errors
  • 739d98c Remove re-export of rustls-pki-types
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rustls-webpki](https://github.com/rustls/webpki) from 0.102.8 to 0.103.0.
- [Release notes](https://github.com/rustls/webpki/releases)
- [Commits](rustls/webpki@v/0.102.8...v/0.103.0)

---
updated-dependencies:
- dependency-name: rustls-webpki
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner February 25, 2025 10:38
@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Feb 25, 2025
@cratelyn cratelyn self-assigned this Feb 25, 2025
the default features of the `rustls-webpki` library were changed in
rustls/webpki#302. see this relevant snippet of the diff in
`Cargo.toml`:

```diff
-default = ["std", "ring"]
+default = ["std"]
```

https://github.com/rustls/webpki/pull/302/files#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542

this commit adds this flag that we were implicitly using before this
change, via default features.

Signed-off-by: katelyn martin <[email protected]>
@@ -62,6 +62,8 @@ skip = [
# Some dependencies still use indexmap v1.
{ name = "indexmap", version = "1" },
{ name = "hashbrown", version = "0.12" },
# `rustls` v0.23.23 has not upgraded to rustls-webpki v0.103.0.
{ name = "rustls-webpki", version = "0.102.8"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we wait until the next version of rustls to come out before upgrading this too?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't have a particularly strong conviction about that, but that might make sense!

if so, perhaps this crate should be placed in a rustls* group, like our group for opentelemetry* crates? https://github.com/linkerd/linkerd2-proxy/blob/main/.github/dependabot.yml#L27-L30

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a good idea, keeping them in lockstep would help keep ecosystem changes like this together.

Copy link
Member

@olix0r olix0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree that we want these kept in lock step and don't want to allow dupe versions of this crate if it all possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants