-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump rustls-webpki from 0.102.8 to 0.103.0 #3650
base: main
Are you sure you want to change the base?
Conversation
Bumps [rustls-webpki](https://github.com/rustls/webpki) from 0.102.8 to 0.103.0. - [Release notes](https://github.com/rustls/webpki/releases) - [Commits](rustls/webpki@v/0.102.8...v/0.103.0) --- updated-dependencies: - dependency-name: rustls-webpki dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
the default features of the `rustls-webpki` library were changed in rustls/webpki#302. see this relevant snippet of the diff in `Cargo.toml`: ```diff -default = ["std", "ring"] +default = ["std"] ``` https://github.com/rustls/webpki/pull/302/files#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542 this commit adds this flag that we were implicitly using before this change, via default features. Signed-off-by: katelyn martin <[email protected]>
Signed-off-by: katelyn martin <[email protected]>
@@ -62,6 +62,8 @@ skip = [ | |||
# Some dependencies still use indexmap v1. | |||
{ name = "indexmap", version = "1" }, | |||
{ name = "hashbrown", version = "0.12" }, | |||
# `rustls` v0.23.23 has not upgraded to rustls-webpki v0.103.0. | |||
{ name = "rustls-webpki", version = "0.102.8"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we wait until the next version of rustls to come out before upgrading this too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't have a particularly strong conviction about that, but that might make sense!
if so, perhaps this crate should be placed in a rustls*
group, like our group for opentelemetry*
crates? https://github.com/linkerd/linkerd2-proxy/blob/main/.github/dependabot.yml#L27-L30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's a good idea, keeping them in lockstep would help keep ecosystem changes like this together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I agree that we want these kept in lock step and don't want to allow dupe versions of this crate if it all possible.
Bumps rustls-webpki from 0.102.8 to 0.103.0.
Release notes
Sourced from rustls-webpki's releases.
Commits
5c72344
Include ignored tests in coverage measurementd800833
Run all tests in CI9da0b63
build(deps): bump cryptography from 44.0.0 to 44.0.184b1463
rustfmt: style_edition 202459f69f3
build(deps): bump seanmiddleditch/gha-setup-ninja from 5 to 6a182fb0
Add context toCrlExpired
errors3f08209
Test for cert time validitydee8d0a
Add context toCertExpired
errors1c770af
Add context toCertNotValidYet
errors739d98c
Remove re-export of rustls-pki-typesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)