Docs: Correcting Prometheus scrape configuration for Multi-Cluster. #1910
+12
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fragglehunter
changed the title
|
@fragglehunter Can you provide some context around this change, and suggest someone who could review it? |
|
This update is to fix the service-mirror section in the Prometheus scrape configuration and align it to whats include with the See example here: ref. If using multicluster, the current configuration prevents the Gateway tab showing up in the viz web UI. @kflynn would be a good reviewer as we have had some back and forth on the bring your own prometheus topic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scrape configuration on the Linkerd website has a mistake in it that prevents service-mirror metrics from being scraped and showing up in the Viz Dashboard.