Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vetka2 #124

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open
26 changes: 23 additions & 3 deletions csharp/Platform.Collections/ICollectionExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,37 @@ public static class ICollectionExtensions
/// <para>Checking collection for empty.</para>
/// <para>Проверяет коллекцию на пустоту.</para>
/// </summary>
/// <typeparam name="T">
/// <para>Collection element data type.</para>
Copy link
Member

@TwinkmrMask TwinkmrMask Jun 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The elements collection data type. may be.

/// <para>Тип данных элемента коллекций.</para>
/// </typeparam>
/// <param name="collection">
/// <para>Method takes an elements collection of <see cref="ICollection<T>"/> type.</para>
/// <para>Метода принимает колекцию элементов <see cref="ICollection<T>"/> типа.</para>
/// <para>Метод принимает колекцию элементов <see cref="ICollection<T>"/> типа.</para>
Copy link
Member

@TwinkmrMask TwinkmrMask Jun 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't say that this is a method, just write what it does
You need to remove the word Method

/// </param>
/// <returns>
/// <para>Returns a <see cref="bool"/> type variable equal to False if the collection is empty else returns true.</para>
/// <para>Returns a <see cref="bool"/> type variable equal to false if the collection is empty else returns true.</para>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can say just The <see cref="bool"/> type variable equal to false if the collection is empty else returns true.

/// <para>Возвращает переменную типа <see cref="bool"/> равной false если коллекция пустая иначе возвращает true.</para>
FreePhoenix888 marked this conversation as resolved.
Show resolved Hide resolved
/// </returns>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static bool IsNullOrEmpty<T>(this ICollection<T> collection) => collection == null || collection.Count == 0;


/// <summary>
/// <para>Checks if all elements of the collection are standard values of type.</para>
/// <para>Проверяет являются ли все элементы коллекции значениями по умолчанию типа.</para>
Copy link
Member

@TwinkmrMask TwinkmrMask Jun 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can say <see cref="default"/> instead are standard values of type.

/// </summary>
/// <typeparam name="T">
/// <para>Collection elements data type.</para>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you have a collection in the singular

/// <para>Тип данных элементов коллекций.</para>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here is a collection in the plural, please decide

/// </typeparam>
/// <param>
/// <para>Method takes an elements collection of <see cref="ICollection<T>"/> type.</para>
/// <para>Метод принимает колекцию элементов <see cref="ICollection<T>"/> типа.</para>
/// </param>
/// <returns>
/// <para>Returns a variable of type <see cref="bool"/> equal to true if all elements in the collection are default values else returns false.</para>
Copy link
Member

@FreePhoenix888 FreePhoenix888 Jun 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returns a variable of type <see cref="bool"/> equal to true if all elements in the collection are default values else returns false. -> Gets a <see cref="bool"/> value that determines whether all collection elements values are equal to the default values.

/// <para>Возвращает переменную типа <see cref="bool"/> равной true если все элементы коллекции являются значениями по умолчанию иначе возвращает false.</para>
Copy link
Member

@FreePhoenix888 FreePhoenix888 Jun 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Возвращает переменную типа <see cref="bool"/> равной true если все элементы коллекции являются значениями по умолчанию иначе возвращает false.->Возвращает значение типа <see cref="bool"/>, определяющее, равны ли все значения элементов коллекции <see cref="default"/> значениям.

/// </returns>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static bool AllEqualToDefault<T>(this ICollection<T> collection)
{
Expand Down