fix possible error on empty sentences

linto-ai · Apr 25, 2023 · def5330 · def5330
1 parent 24f581d
commit def5330
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/RELEASE.md b/RELEASE.md
@@ -1,3 +1,6 @@
+# 1.1.1
+- Fix error on empty sentences
+
 # 1.1.0
 - Added service registration
 - Updated README
@@ -11,4 +14,4 @@
 
 # 1.0.0
 - Punctuation service.
-- HTTP or Celery serving.
+- HTTP or Celery serving.
diff --git a/celery_app/tasks.py b/celery_app/tasks.py
@@ -41,7 +41,9 @@ def punctuation_task(self, text: Union[str, list]):
         else:
             print("Failed to predict punctuation on sentence: >{sentence}<")
             punctuated_sentence = sentence
-        punctuated_sentence = punctuated_sentence[0].upper() + punctuated_sentence[1:]
+        # First letter in capital
+        if len(punctuated_sentence):
+            punctuated_sentence = punctuated_sentence[0].upper() + punctuated_sentence[1:]
         punctuated_sentences.append(punctuated_sentence)
 
     return (

diff --git a/http_server/ingress.py b/http_server/ingress.py
@@ -61,9 +61,10 @@ def punctuate():
             if result.status_code == 200:
                 punctuated_sentence = result.text
                 # First letter in capital
-                punctuated_sentence = (
-                    punctuated_sentence[0].upper() + punctuated_sentence[1:]
-                )
+                if len(punctuated_sentence):
+                    punctuated_sentence = (
+                        punctuated_sentence[0].upper() + punctuated_sentence[1:]
+                    )
                 punctuated_sentences.append(punctuated_sentence)
             else:
                 raise Exception(result.text)