Merge pull request #372 from martin-belanger/v2.2.3-rc1

udev-rules: Only react to `rediscover` events (not `connected`)
linux-nvme · Jun 12, 2023 · 3547a04 · 3547a04
2 parents fd07276 + 31f187f
commit 3547a04
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,12 @@
 # STorage Appliance Services (STAS)
 
+## Changes with release 2.2.3
+
+Bug fixes:
+
+* When processing kernel nvme events, only react to `rediscover` and not to `connected` events. The `connected` event happens too early (before the nvme device has been fully identified).
+* 
+
 ## Changes with release 2.2.2
 
 Bug fixes:

diff --git a/meson.build b/meson.build
@@ -9,7 +9,7 @@
 project(
     'nvme-stas',
     meson_version: '>= 0.53.0',
-    version: '2.2.2',
+    version: '2.2.3-rc1',
     license: 'Apache-2.0',
     default_options: [
         'buildtype=release',

diff --git a/staslib/service.py b/staslib/service.py
@@ -856,7 +856,7 @@ def _nvme_cli_interop(self, udev_obj):
                 return
 
         # Did we receive a Change of DLP AEN or an NVME Event indicating 'connect' or 'rediscover'?
-        if not _is_dlp_changed_aen(udev_obj) and not _event_matches(udev_obj, ('connected', 'rediscover')):
+        if not _is_dlp_changed_aen(udev_obj) and not _event_matches(udev_obj, ('rediscover',)):
             return
 
         # We need to invoke "nvme connect-all" using nvme-cli's [email protected]