mana: Remove redundant checks on max_send_sge and max_sge

max_send_sge for QP and max_sge for WQ are already checked in the kernel. There is no need to check here. Signed-off-by: Long Li <[email protected]>
linux-rdma · Nov 10, 2023 · cde5d9c · cde5d9c
1 parent 3bbc4f7
commit cde5d9c
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 18 deletions.
diff --git a/providers/mana/mana.h b/providers/mana/mana.h
@@ -17,8 +17,6 @@
 #define INLINE_OOB_LARGE_SIZE 24
 
 #define GDMA_WQE_ALIGNMENT_UNIT_SIZE 32
-#define MAX_TX_WQE_SIZE 512
-#define MAX_RX_WQE_SIZE 256
 
 /* The size of a SGE in WQE */
 #define SGE_SIZE 16

diff --git a/providers/mana/qp.c b/providers/mana/qp.c
@@ -56,14 +56,6 @@ static struct ibv_qp *mana_create_qp_raw(struct ibv_pd *ibpd,
 
 	cq = container_of(attr->send_cq, struct mana_cq, ibcq);
 
-	if (get_wqe_size(attr->cap.max_send_sge) > MAX_TX_WQE_SIZE) {
-		verbs_err(verbs_get_ctx(ibpd->context),
-			  "max_send_sge %d exceeding queue size limits\n",
-			  attr->cap.max_send_sge);
-		errno = EINVAL;
-		return NULL;
-	}
-
 	if (!ctx->extern_alloc.alloc || !ctx->extern_alloc.free) {
 		verbs_err(verbs_get_ctx(ibpd->context),
 			  "RAW QP requires extern alloc for buffers\n");

diff --git a/providers/mana/wq.c b/providers/mana/wq.c
@@ -41,14 +41,6 @@ struct ibv_wq *mana_create_wq(struct ibv_context *context,
 	struct mana_create_wq_resp wq_resp = {};
 	struct mana_ib_create_wq *wq_cmd_drv;
 
-	if (get_wqe_size(attr->max_sge) > MAX_RX_WQE_SIZE) {
-		verbs_err(verbs_get_ctx(context),
-			  "max_sge %d exceeding WQE size limit\n",
-			  attr->max_sge);
-		errno = EINVAL;
-		return NULL;
-	}
-
 	if (!ctx->extern_alloc.alloc || !ctx->extern_alloc.free) {
 		verbs_err(verbs_get_ctx(context),
 			  "WQ buffer needs to be externally allocated\n");