Some fixes found while playing with clang scan-build #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fixes lines should all be in the trailer block, no blank line before the signed-off-vy |
In case of malloc error, not all allocated memory is freed. Cleanup all error handling to make sure every thing is properly freed. Fixes: fb11e5a ("libibmad: Add new API to support SMI/GSI seperation") Signed-off-by: Nicolas Morey <[email protected]>
clang static analyzer is getting confused by ibexit as it is not marked as noreturn. Add the noreturn attribute to silence a few false bugs. Signed-off-by: Nicolas Morey <[email protected]>
dr_arg_obj are wrongly allocated as dr_arg_pool. Fix by using the correct type for allocation. Fixes: 97f573f ("mlx5: DR, Add modify_header_arg pool mechanism") Signed-off-by: Nicolas Morey <[email protected]>
If realloc fails, info pointers is being set to NULL although its original memory has not been freed. Use a temporary pointer to be able to free the original memory in case realloc fails. Fixes: bfc56ce ("mlx5: Setup mlx5 vfio context") Signed-off-by: Nicolas Morey <[email protected]>
|
Should be fixed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.