Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call to LockFront1 dbus service is blocked in wayland #1048

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

yixinshark
Copy link
Contributor

as title

Log: as title
Pms: BUG-304355

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, yixinshark

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

as title

Log: as title
Pms: BUG-304355
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • NotificationManager的构造函数中,添加了对平台名称的检查,以确保只有在非Wayland平台上才调用initScreenLockedState函数。

是否建议立即修改:

  • 否,这个改动看起来是有意为之的,以避免在Wayland平台上调用initScreenLockedState函数。但是,需要确保这个改动是经过充分测试的,并且不会引入新的问题。

其他建议:

  • 确保在添加平台检查后,所有相关的测试用例都已更新,以覆盖新的代码路径。
  • 如果initScreenLockedState函数在Wayland平台上不需要,可以考虑移除这个函数,或者提供一个替代的实现。
  • 添加注释说明为什么在Wayland平台上不调用initScreenLockedState函数,以便其他开发者理解这一改动的原因。

@yixinshark
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Feb 25, 2025

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 2eff68a into linuxdeepin:master Feb 25, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants