Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: Remove Thumbnailer dependency (#294)" #295

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

pengfeixx
Copy link
Contributor

This reverts commit 0b8cd83.

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • imageitem.cpp文件中,异常捕获块中的代码被重复使用了,应该将其提取到一个单独的函数中以提高代码的可读性和可维护性。
  • malloc_trim(0);在每次调用generateThumbnail时都被调用,这可能是不必要的,应该确认其必要性。
  • getLoadLibsInstance()->m_video_thumbnailer();在每次调用generateThumbnail时都被调用,这可能是不必要的,应该确认其必要性。
  • getLoadLibsInstance()->m_video_thumbnailer_create_image_data();在每次调用generateThumbnail时都被调用,这可能是不必要的,应该确认其必要性。
  • getLoadLibsInstance()->m_video_thumbnailer_destroy_image_data(m_image_data);在每次调用generateThumbnail后都被调用,这可能是不必要的,应该确认其必要性。
  • getLoadLibsInstance()->m_video_thumbnailer_destroy(m_video_thumbnailer);在每次调用generateThumbnail后都被调用,这可能是不必要的,应该确认其必要性。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, pengfeixx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pengfeixx pengfeixx merged commit be33ea8 into linuxdeepin:master Jun 14, 2024
14 checks passed
@pengfeixx pengfeixx deleted the revert branch June 14, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants