Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove invalid url #341

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix: remove invalid url #341

merged 1 commit into from
Dec 20, 2024

Conversation

wyu71
Copy link
Contributor

@wyu71 wyu71 commented Dec 20, 2024

remove invalid url

Log: remove invalid url

remove invalid  url

Log: remove invalid  url
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. 注释更新

    • 在多个文件的mouseMoveEvent函数中,注释已经从包含完整的bug链接更新为只包含bug编号。这是一个好的做法,因为链接可能不总是必要的,特别是当bug已经解决或不再需要时。
  2. 代码重复

    • 所有文件的mouseMoveEvent函数实现几乎完全相同,只是注释中的bug编号不同。这表明这些函数可能可以合并为一个通用的函数,以减少代码重复。
  3. 未使用的参数

    • 使用Q_UNUSED(event);来忽略未使用的参数是一个好的实践,但在这个特定的场景中,如果event参数确实不需要,那么直接删除Q_UNUSED(event);return;语句可能会更清晰。
  4. 注释清晰度

    • 注释应该清晰地描述问题,而不是仅仅引用bug编号。如果bug编号是问题的唯一标识,那么注释应该更详细地说明问题的上下文和解决方案。
  5. 代码风格

    • 虽然代码风格可能因个人或团队的偏好而异,但保持一致的代码风格有助于提高代码的可读性和维护性。例如,注释的格式应该在整个项目中保持一致。

综合以上意见,建议对代码进行如下修改:

  • 合并mouseMoveEvent函数,以减少代码重复。
  • 更新注释,使其更加清晰和详细。
  • 如果event参数确实不需要,则删除Q_UNUSED(event);return;语句。

示例代码修改:

// 解决bug 在按钮中可拖动相机界面,bug 100647
void circlePushButton::mouseMoveEvent(QMouseEvent *event)
{
    // 更详细的注释,说明问题的上下文和解决方案
    Q_UNUSED(event);
    // 如果event参数确实不需要,可以删除以下语句
    // return;
}

对于其他文件中的mouseMoveEvent函数,可以采用类似的方式进行修改。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pengfeixx, wyu71

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wyu71 wyu71 merged commit 510be1b into linuxdeepin:master Dec 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants