Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install package failed #286

Merged
merged 2 commits into from
Dec 5, 2024
Merged

fix: install package failed #286

merged 2 commits into from
Dec 5, 2024

Conversation

rb-union
Copy link
Contributor

@rb-union rb-union commented Dec 5, 2024

fix: assume yes in immutable install

As title.

Log: Fixed an issue that blocked the installation.
Bug: https://pms.uniontech.com/bug-view-291783.html
Influence: immutable

fix: get uab meta info failed

Require uab file executable,
to get the meta info via --print-meta.

Log: Fix get uab meta info failed.
Bug: https://pms.uniontech.com/bug-view-292129.html
Influence: uab-package

As title.

Log: Fixed an issue that blocked the installation.
Bug: https://pms.uniontech.com/bug-view-291783.html
Influence: immutable
@rb-union rb-union changed the title fix: get uab meta info failed fix: install package failed Dec 5, 2024
Require uab file executable,
to get the meta info via --print-meta.

Log: Fix get uab meta info failed.
Bug: https://pms.uniontech.com/bug-view-292129.html
Influence: uab-package
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. installDebThread.cpp文件中,移除了与不可变系统相关的常量定义和注释,这可能会影响其他部分的代码。如果这些常量不再使用,应该确保没有其他代码依赖于它们,否则应该保留这些定义和注释。

  2. installDebThread.cpp文件中,immutableProcess函数中添加了kImmuYes参数来确认安装操作,这是一个好的做法,因为它增加了代码的可读性和可维护性。

  3. uab_backend.cpp文件中,uabExecuteOutput函数增加了对UAB文件存在性的检查,这是一个很好的安全措施,可以防止执行不存在的文件。

  4. uab_backend.cpp文件中,uabExecuteOutput函数在执行UAB文件之前临时设置了可执行权限,这是一个合理的做法,但应该确保在执行完毕后恢复文件的原始权限,以避免潜在的安全风险。

  5. uab_backend.cpp文件中,uabExecuteOutput函数增加了错误信息输出,这是一个好的做法,可以帮助调试和错误追踪。

  6. uab_backend.cpp文件中,uabExecuteOutput函数在设置文件权限时使用了QFile::ExeOwner | QFile::ExeUser | QFile::ExeGroup,这是一个合理的权限设置,但应该确保这些权限是必要的,并且不会对文件的安全性产生负面影响。

总体来说,代码的改动提高了代码的可读性和安全性,但需要注意确保移除的常量定义和注释不会影响其他部分的代码。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pengfeixx, rb-union

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@myk1343 myk1343 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@rb-union rb-union merged commit 9e048b0 into linuxdeepin:master Dec 5, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants