Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: too much latency when drawing on 4k screens #94

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

wyu71
Copy link
Contributor

@wyu71 wyu71 commented Jul 2, 2024

The entire area is refreshed when drawing

Log: The delay is too high when drawing on a 4k screen
Bug: https://pms.uniontech.com/bug-view-262599.html

The entire area is refreshed when drawing

Log: The delay is too high when drawing on a 4k screen
Bug: https://pms.uniontech.com/bug-view-262599.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • paintPictureToView函数中,view->viewport()->update(trans.mapRect(picture.boundingRect()));可能会导致性能问题,因为它会频繁地更新视口。建议在需要时进行更新。
  • eventFilter函数中没有对事件类型进行判断,可能会导致未处理的事件。建议添加对事件类型的检查,以避免潜在的崩溃。

是否建议立即修改:

Copy link
Contributor

@starhcq starhcq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/+1

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: starhcq, wyu71

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@starhcq starhcq merged commit 53d5718 into linuxdeepin:master Jul 2, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants