Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Possible null pointer dereference and Notitlebar input parameter error #278

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Nov 26, 2024

…ter references

as title

pms: Task-368711

@mhduiy mhduiy requested a review from 18202781743 November 26, 2024 03:44
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Nov 26, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#278
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Nov 26, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#278
@mhduiy mhduiy changed the title fix: DTreeLandPlatformWindowInterface release may result in null poin… fix: Possible null pointer dereference and Notitlebar input parameter error Nov 26, 2024
18202781743
18202781743 previously approved these changes Nov 26, 2024
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Nov 26, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#278
18202781743
18202781743 previously approved these changes Nov 26, 2024
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Nov 26, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#278
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • DPlatformHandle的析构函数中,使用g_platformThemeMap.take(this)替代了原来的valueremove方法,这是一个更安全、更高效的操作。
  • setEnabledNoTitlebarForWindow函数中,直接将enable参数传递给handle->setEnabledNoTitlebar,避免了不必要的布尔值比较。

是否建议立即修改:

  • 否,提交的代码已经改进了原有的逻辑,没有发现需要立即修改的问题。

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy mhduiy merged commit e10215f into linuxdeepin:master Nov 26, 2024
22 of 24 checks passed
mhduiy pushed a commit to linuxdeepin/dtk6gui that referenced this pull request Nov 26, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#278
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants