Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app crashed when window destroyed in quick #283

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

18202781743
Copy link
Contributor

as title.

pms: BUG-368399

@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • MoveWindowHelper::windowEvent函数中新增了对QEvent::DeferredDelete事件的特殊处理,但未提供完整的上下文和注释说明为什么需要重置虚表。
  • 新增代码中使用了DVtableHook::resetVtable(w),但没有说明这个函数的具体作用和影响。

是否建议立即修改:

建议的修改措施:

  • 为新增的QEvent::DeferredDelete事件处理添加详细的注释,说明为什么需要重置虚表,以及这个操作可能带来的影响。
  • 确认DVtableHook::resetVtable(w)函数的实现和其具体作用,确保这个操作是必要的,并且不会引入新的问题。
  • 如果DVtableHook::resetVtable(w)是一个自定义的函数,建议提供其实现细节,以便其他开发者理解其用途。
  • 考虑是否有必要将windowEvent函数改为静态函数,并传递self参数,这可能会影响类的封装性和可测试性,需要评估这一改动的必要性。

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Nov 29, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#283
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, FeiWang1119

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit 726790e into linuxdeepin:master Nov 30, 2024
22 of 24 checks passed
18202781743 pushed a commit to linuxdeepin/dtk6gui that referenced this pull request Nov 30, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants