Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: window blur invalid #285

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix: window blur invalid #285

merged 1 commit into from
Dec 3, 2024

Conversation

mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Dec 2, 2024

Set blur again when creating the surface

pms: BUG-278281

@mhduiy mhduiy requested a review from 18202781743 December 2, 2024 09:28
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 2, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#285
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 2, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#285
18202781743
18202781743 previously approved these changes Dec 2, 2024
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 2, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#285
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 3, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#285
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 3, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#285
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 3, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#285
@mhduiy mhduiy requested a review from 18202781743 December 3, 2024 02:59
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 3, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#285
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 3, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#285
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, justforlxz, mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Set blur again when creating the surface

pms: BUG-278281
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • DTreeLandPlatformWindowInterface类中,initWaylandWindow函数中使用了dynamic_cast来获取QWaylandWindow指针,但没有处理转换失败的情况。
  • onSurfaceCreatedonSurfaceDestroyed函数中,m_windowContext的删除和释放逻辑可能存在潜在的内存泄漏问题,因为deleteLater调用后,指针可能不会立即被删除。
  • doSetEnabledNoTitlebardoSetEnabledBlurWindow函数中,handleFunc的调用方式可能会导致线程安全问题,特别是在多线程环境下。
  • setEnabledNoTitlebarsetEnableBlurWindow函数中,增加了对m_isNoTitlebarm_isWindowBlur的检查,这有助于避免不必要的函数调用,但应确保这些函数在其他地方也有相应的检查。

是否建议立即修改:

  • 应该立即处理dynamic_cast转换失败的情况,以避免潜在的运行时错误。
  • 对于m_windowContext的删除和释放逻辑,需要确保在所有可能的路径下都能正确处理,避免内存泄漏。
  • 对于handleFunc的调用方式,需要确认其线程安全性,如果存在多线程问题,应该进行适当的同步处理。
  • 对于setEnabledNoTitlebarsetEnableBlurWindow函数中的检查,应该确保这些检查在其他相关的地方也有相应的处理,以保持代码的一致性和可维护性。

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 3, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#285
@mhduiy mhduiy merged commit 00584ef into linuxdeepin:master Dec 3, 2024
22 of 24 checks passed
mhduiy pushed a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 3, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants