Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set font family invalid #294

Merged
merged 1 commit into from
Jan 1, 2025
Merged

fix: set font family invalid #294

merged 1 commit into from
Jan 1, 2025

Conversation

mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Dec 31, 2024

FamilyResolved flag not set

pms: BUG-295665

FamilyResolved flag not set

pms: BUG-295665
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • 在新增代码中,font.setFamilies(base.families()); 可能会导致不必要的性能开销,因为每次调用 get 方法时都会重新设置字体家族。

是否建议立即修改:

  • 是,建议评估是否真的需要每次都重新设置字体家族,或者是否有更高效的方法来管理字体家族。如果这个设置是必要的,可以考虑缓存字体家族,避免每次都重新设置。

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 31, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#294
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy mhduiy merged commit e0873d0 into linuxdeepin:master Jan 1, 2025
22 of 24 checks passed
mhduiy pushed a commit to linuxdeepin/dtk6gui that referenced this pull request Jan 1, 2025
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#294
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants