system-monitor-graph@rcassani: Add error handling for amdgpu #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds error checking to prevent desklet or cinnamon crashes when any of the used files are absent from the system, most often because the system doesn't have a gpu from AMD. It also switches amdgpu functions to use async function calls for file reading, like the rest of the desklet.
Last commit introduces a race condition that breaks amdgpu memory readout, this fixes it
|
@Lazar-Kovacevic, please find my contribution to this development in the PR towards your |
GPUs error handling
|
Done, from my testing everything works as intended @rcassani. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits add error checking to prevent desklet or cinnamon crashes when any of the used files are absent from the system, most often because the system doesn't have a gpu from AMD.
It also switches amdgpu functions to use async function calls for file reading, like the rest of the desklet.
@rcassani Sorry for submitting broken code last time, I did a lot more testing this time and it seems to be ok.