gjs-util: Backport private closure annotations patch #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Small detail: used in Debian after a new fails to build with recent gobject-introspection became a bit more strict, I think will be useful also for latest version of other distro |
From: Philip Chimento <[email protected]> Date: Sat, 27 Jul 2024 20:17:39 -0700 Subject: GjsPrivate: Fix closure annotations Apparently the closure annotation can be omitted if the parameter is named user_data. If it is needed because the parameter is not named user_data then the annotation should be on the callback argument and refer to the user data argument. Ref: https://gitlab.gnome.org/GNOME/gjs/-/commit/1df5d72d8df383199dcd88cd1d16209617bf32ca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: Philip Chimento [email protected]
Date: Sat, 27 Jul 2024 20:17:39 -0700
Subject: GjsPrivate: Fix closure annotations
Apparently the closure annotation can be omitted if the parameter is named user_data. If it is needed because the parameter is not named user_data then the annotation should be on the callback argument and refer to the user data argument.
Ref:
https://gitlab.gnome.org/GNOME/gjs/-/commit/1df5d72d8df383199dcd88cd1d16209617bf32ca