Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added: open links in new tab - accidentally navigating away from current page is a pita! #526

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

srmcgann
Copy link
Contributor

@srmcgann srmcgann commented Nov 1, 2021

added: open links in new tab - accidentally navigating away from current page is a pita!

Copy link
Owner

@lionleaf lionleaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree links in comments should open in a new tab! Thanks for the contribution :)

@lionleaf lionleaf merged commit 529e4a8 into lionleaf:master Nov 9, 2021
@ThomasBrierley
Copy link
Collaborator

Is this referring to losing changes to the textarea upon navigation?

Interestingly Firefox has saved me from this a number of times because it autofills previously changed fields based on history navigation... for a short time at least.

I'm wondering if we should implement something similar as a more general solution to this type of problem for all browsers.
I'm imagining some combination of localStorage with history and dweet id to differentiate between windows into the same dweet... although that would not uniquely identify it since the only history property we can use is history.length i think. Maybe with a timestamp to limit how long until it's "forgotten" would minimise mix-ups, i.e so we try to only affect accidental navigation of any kind... assuming people hit back, do they?

Just an idea. I'm aware of feature creep, so we shouldn't implement it if it doesn't sound useful enough.

@lionleaf
Copy link
Owner

You could also lose your scroll location etc.

But I think a localstorage draft system could make sense. This is the closest issue I could find about it: #407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants