-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanded support for Libcamera Controls (ControlInfoMap and ControlInfo) #46
base: main
Are you sure you want to change the base?
Conversation
I realized I skipped over the values method inside of ControlInfo. I have added an implementation that appears to work with the same systems mentioned before. I also expanded on top of the libcamera-meta to allow getting the id and names of the ControlId/PropertyId from the enum directly. |
let libcamera_version = Version::new( | ||
libcamera_sys::LIBCAMERA_VERSION_MAJOR as _, | ||
libcamera_sys::LIBCAMERA_VERSION_MINOR as _, | ||
libcamera_sys::LIBCAMERA_VERSION_PATCH as _, | ||
); | ||
let libcamera_version = Version::new(0, 3, 2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi if your doing this so you can cross compile i hope #48 should help, could you try it yourself to confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey sorry for the hold up, yes it in fact did work! for cross and on my host machine.
I believe i have implemented the rest of ControlInfoMap and ControlInfo and created a few methods to turn it into an iterator.
I have tested on my host machine (Libcamera 0.3.1, Fedora 40 - x86) and with cross compiling to arm64 (Libcamera 0.3.2, Debian Bookworm). The code works on both x86 and arm64 (tested with a compute module 4).
I am working on a project that requires quite extensive information from libcamera so I will continue to make pull request as I expand libcamera-sys and libcamera to support the remaining missing implementation I need