Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for ChangHong KFR-35GW/DHR(W1-H)+2 #189

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ghostist
Copy link

this pr works for me.only support Xiaomi IR Remote.I only own this ir device.

@litinoveweedle
Copy link
Owner

Hello @ghostist , thank you for your contribution. I did quickly checked your codes and I want to ask you to consider one small change. You seems to to using duplicate commands for fan_only (and maybe also for dry?) mode:

    "fan_only": {
      "low": {
        "16": "nEznMylk0mUxmMsms0nIAcTGbTKZAEaAz4CHgISAH4JfgM+Az4AfgB+AH4AfgB+AH4AfgB+FD4CngMeAh4CHgB+AH4AfgB+AH4AfgB+AH4AfgB+AH4AfgB+AH4AfgB+AH4AfgB+AH4AfgB+AH4AfgB+AH4AfgB+AH4AfgB+AH4AfgB+AH5IHgIeBT4DHgMXMJhMA",
        "17": "nEznMylk0mUxmMsms0nIAcTGbTKZAEaAz4CHgISAH4JfgM+Az4AfgB+AH4AfgB+AH4AfgB+FD4CngMeAh4CHgB+AH4AfgB+AH4AfgB+AH4AfgB+AH4AfgB+AH4AfgB+AH4AfgB+AH4AfgB+AH4AfgB+AH4AfgB+AH4AfgB+AH4AfgB+AH5IHgIeBT4DHgMXMJhMA",
        "18": 

This is completely unnecessary as it is possible to provide the command just once and instead of temperature value (i.e. 17) use - as a key. Would you please consider this change? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants