Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slovak language #230

Merged
merged 7 commits into from
Jun 20, 2019
Merged

Add Slovak language #230

merged 7 commits into from
Jun 20, 2019

Conversation

majko96
Copy link
Contributor

@majko96 majko96 commented Jun 18, 2019

SK

This PR/Translation is about #ISSUE_NUMBER.

files translated:

  • def/--LOCALE-CODE--/about.cson
  • def/--LOCALE-CODE--/context.cson
  • def/--LOCALE-CODE--/menu_darwin.cson
  • def/--LOCALE-CODE--/menu_linux.cson
  • def/--LOCALE-CODE--/menu_win32.cson
  • def/--LOCALE-CODE--/settings.cson
  • def/--LOCALE-CODE--/welcome.cson

validation

  • I've validated my translation locally by running

npm run validation -- --locale MY_LOCALE

about.cson, context.cson, menu_darwin.cson, menu_linux.cson and welcome.cson are completely translated.
to be continued... :)

@majko96 majko96 requested a review from liuderchi as a code owner June 18, 2019 16:36
Copy link
Owner

@liuderchi liuderchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to Slovak translation! 🙇‍♂️
Please help with some fixes to pass CI.

def/sk/menu_linux.cson Outdated Show resolved Hide resolved
def/sk/menu_linux.cson Outdated Show resolved Hide resolved
BuildTools added 6 commits June 19, 2019 18:32
@majko96
Copy link
Contributor Author

majko96 commented Jun 19, 2019

I think that now everything should be fine.... :)

@liuderchi liuderchi self-requested a review June 20, 2019 15:14
@liuderchi liuderchi merged commit 8bed912 into liuderchi:master Jun 20, 2019
@liuderchi liuderchi added the i18n sk Slovak translation label Jun 21, 2019
@liuderchi
Copy link
Owner

@majko96 Slovak translation has released in latest atom-i18n v0.21.0 🎉
If you’d like to translate more into Slovak please refer issue #231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n sk Slovak translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants