review comment: add comment

livepeer · Feb 26, 2025 · 24d805f · 24d805f
1 parent e500951
commit 24d805f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/balancer/catabalancer/catalyst_balancer.go b/balancer/catabalancer/catalyst_balancer.go
@@ -412,6 +412,7 @@ func (c *CataBalancer) MistUtilLoadSource(ctx context.Context, streamID, lat, lo
 }
 
 var StatsUpdateInterval = 5 * time.Second
+var StatsUpdateTimeout = StatsUpdateInterval - 500*time.Millisecond // have the timeout sit within the update interval so we don't miss sending updates
 
 func isStale(timestamp time.Time, stale time.Duration) bool {
 	return time.Since(timestamp) >= stale
@@ -478,7 +479,7 @@ func sendMetrics(nodeName string, latitude float64, longitude float64, mist clie
 
 func sendMetricsToDB(nodeStatsDB *sql.DB, nodeName string, payload []byte) {
 	start := time.Now()
-	queryContext, cancel := context.WithTimeout(context.Background(), StatsUpdateInterval)
+	queryContext, cancel := context.WithTimeout(context.Background(), StatsUpdateTimeout)
 	defer cancel()
 	insertStatement := `insert into "node_stats"(
                             "node_id",

diff --git a/main.go b/main.go
@@ -267,7 +267,7 @@ func main() {
 
 		if catabalancerEnabled && nodeStatsDB != nil {
 			if cli.Tags["node"] == "media" { // don't announce load balancing availability for testing nodes
-				mist := clients.NewMistAPIClient(cli.MistUser, cli.MistPassword, cli.MistHost, cli.MistPort, catabalancer.StatsUpdateInterval-time.Second)
+				mist := clients.NewMistAPIClient(cli.MistUser, cli.MistPassword, cli.MistHost, cli.MistPort, catabalancer.StatsUpdateTimeout)
 				catabalancer.StartMetricSending(cli.NodeName, cli.NodeLatitude, cli.NodeLongitude, mist, nodeStatsDB)
 			}
 		}