Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make processingRetryTimeout configurable #3387

Merged
merged 5 commits into from
Feb 12, 2025

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Feb 11, 2025

It was set to 2 seconds which is too low for Live Video to Video (Realtime Video).

It was set to 2 seconds which is too low for Live Video to Video (Realtime Video)
@github-actions github-actions bot added go Pull requests that update Go code AI Issues and PR related to the AI-video branch. labels Feb 11, 2025
@leszko leszko requested review from mjh1 and rickstaa February 11, 2025 09:58
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 5.55556% with 17 lines in your changes missing coverage. Please review.

Project coverage is 32.20410%. Comparing base (66ab0f9) to head (ee854cc).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/livepeer/starter/starter.go 0.00000% 12 Missing ⚠️
server/ai_session.go 0.00000% 3 Missing ⚠️
server/ai_process.go 0.00000% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3387         +/-   ##
===================================================
- Coverage   32.20719%   32.20410%   -0.00309%     
===================================================
  Files            147         147                 
  Lines          40640       40647          +7     
===================================================
+ Hits           13089       13090          +1     
- Misses         26779       26785          +6     
  Partials         772         772                 
Files with missing lines Coverage Δ
cmd/livepeer/livepeer.go 56.03448% <100.00000%> (+0.19032%) ⬆️
core/livepeernode.go 74.01575% <ø> (ø)
server/ai_process.go 0.59778% <0.00000%> (-0.00102%) ⬇️
server/ai_session.go 2.51799% <0.00000%> (ø)
cmd/livepeer/starter/starter.go 7.43494% <0.00000%> (-0.01848%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66ab0f9...ee854cc. Read the comment docs.

Files with missing lines Coverage Δ
cmd/livepeer/livepeer.go 56.03448% <100.00000%> (+0.19032%) ⬆️
core/livepeernode.go 74.01575% <ø> (ø)
server/ai_process.go 0.59778% <0.00000%> (-0.00102%) ⬇️
server/ai_session.go 2.51799% <0.00000%> (ø)
cmd/livepeer/starter/starter.go 7.43494% <0.00000%> (-0.01848%) ⬇️

... and 2 files with indirect coverage changes

@leszko leszko merged commit da84ef0 into master Feb 12, 2025
17 of 18 checks passed
@leszko leszko deleted the rafal/configurable-retry-processing branch February 12, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Issues and PR related to the AI-video branch. go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants