This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
sdk: fix inconsistent return type of getJob() #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the test failure is due to #319 |
Fixes livepeer#319 Two tweaks here — `beforeEach` instead of `before` and some tweaks to async loops so they actually wait until the end — forEach will return immediately and cause a false positive.
iameli
force-pushed
the
sdk-test-polish
branch
from
8700228
to
bdd4561
Compare
iameli
changed the title
ericxtang
approved these changes
Feb 1, 2019
|
Cool! I've got another merge request ready as soon as this one can be merged. |
|
(But, ah, I can't merge things into this repo yet 😅) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Fixes #319 and makes the shape of jobs returned by
getJobconsistentSpecific updates (required)
How did you test each of these updates (required)
To the best of my knowledge, I don't believe this
transcoderAddressfield is yet used anywhere — there are no references outside of thesdkandsubgraphprojects.Does this pull request close any open issues?
#319