Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve meta tags #232

Merged
merged 5 commits into from
Nov 2, 2022
Merged

Improve meta tags #232

merged 5 commits into from
Nov 2, 2022

Conversation

Danble
Copy link
Collaborator

@Danble Danble commented Nov 1, 2022

Relevant Issue

SEO issues (maybe #137 )

Summarize what changed in this PR (for developers)

After searching on multiple sites I didn't see any problem on ours, I only took off the width from the shareImage url and it works

Summarize changes in this PR (for public-facing changelog)

We can see correctly all meta data from our site on social media posts:
https://www.opengraph.xyz/url/https%3A%2F%2Fliving-dictionaries-rhn3rbn5u-livingtongues.vercel.app%2Fbirhor%2Fentry%2FRULtL1F2hsyNu3pyF7Ak

How can the changes be tested? Please also provide applicable links using preview deployments once they are available (will require editing this message once the preview deployment is ready).

@vercel
Copy link

vercel bot commented Nov 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
living-dictionaries ✅ Ready (Inspect) Visit Preview Nov 2, 2022 at 2:38PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
ld-parts ⬜️ Ignored (Inspect) Nov 2, 2022 at 2:38PM (UTC)

@Danble Danble requested a review from jacob-8 November 1, 2022 01:27
@jacob-8
Copy link
Collaborator

jacob-8 commented Nov 2, 2022

That's odd that the width breaks things but thanks for figuring that out! Please remove the console log and then you can merge.

@github-actions
Copy link

github-actions bot commented Nov 2, 2022

⚡️ Running Svelte-Check, Jest tests, and Lighthouse audit...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants