Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rest of operations #445

Merged
merged 10 commits into from
Apr 25, 2024
Merged

Conversation

jacob-8
Copy link
Collaborator

@jacob-8 jacob-8 commented Apr 15, 2024

prep work for pull Firebase out of Svelte components and into page load provided functions that can easily be swapped for Supabase versions

@jacob-8 jacob-8 requested a review from Danble as a code owner April 15, 2024 11:54
Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
living-dictionaries ✅ Ready (Inspect) Visit Preview Apr 25, 2024 8:25am

error: string;
}>();
clear: boolean
loading: any

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <ts/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.


return { longitude: result.center[0], latitude: result.center[1] };
return { longitude: result.center[0], latitude: result.center[1] }
}

const handlers: Record<string, any> = {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <ts/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.

click: LngLat
zoomend: number
error: ErrorEvent & EventData
}>()

// More events at https://docs.mapbox.com/mapbox-gl-js/api/map/#map-events
const handlers: Record<string, any> = {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <ts/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.

on:close={() => {
speakerId = '';
on_close={() => {
speakerId = ''

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <svelte/no-reactive-reassign> reported by reviewdog 🐶
Assignment to reactive value 'speakerId'.

speakerId = event.detail.id;
select_speaker?.(speakerId);
on_add_speaker={async (speaker) => {
speakerId = await add_speaker(speaker)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <svelte/no-reactive-reassign> reported by reviewdog 🐶
Assignment to reactive value 'speakerId'.

click: LngLat
zoomend: number
error: ErrorEvent & EventData
}>()

// More events at https://docs.mapbox.com/mapbox-gl-js/api/map/#map-events
const handlers: Record<string, any> = {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <ts/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.

on:close={() => {
speakerId = '';
on_close={() => {
speakerId = ''

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <svelte/no-reactive-reassign> reported by reviewdog 🐶
Assignment to reactive value 'speakerId'.

speakerId = event.detail.id;
select_speaker?.(speakerId);
on_add_speaker={async (speaker) => {
speakerId = await add_speaker(speaker)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <svelte/no-reactive-reassign> reported by reviewdog 🐶
Assignment to reactive value 'speakerId'.

Copy link

Visual Regression Report

148 changed snapshots for living-dictionaries
new old diff
lib/components/audio/UploadAudioStatus - Error-400x200-as
actual-img
lib/components/audio/UploadAudioStatus - Error-400x200-id
actual-img
lib/components/audio/UploadAudioStatus - Error-400x200-en
actual-img
lib/components/audio/UploadAudioStatus - Error-400x200-es
actual-img
lib/components/audio/UploadAudioStatus - Error-400x200-fr
actual-img
lib/components/audio/UploadAudioStatus - Error-400x200-sw
actual-img
lib/components/audio/UploadAudioStatus - Error-400x200-ms
actual-img
lib/components/audio/UploadAudioStatus - Error-400x200-pt
actual-img
lib/components/audio/UploadAudioStatus - Error-400x200-vi
actual-img
lib/components/audio/UploadAudioStatus - Error-400x200-ru
actual-img
lib/components/audio/UploadAudioStatus - Error-400x200-he
actual-img
lib/components/audio/UploadAudioStatus - Error-400x200-hi
actual-img
lib/components/audio/UploadAudioStatus - Error-400x200-bn
actual-img
lib/components/audio/UploadAudioStatus - Error-400x200-zh
actual-img
lib/components/audio/UploadAudioStatus - Success-400x200-as
actual-img
lib/components/audio/UploadAudioStatus - Success-400x200-id
actual-img
lib/components/audio/UploadAudioStatus - Success-400x200-en
actual-img
lib/components/audio/UploadAudioStatus - Success-400x200-es
actual-img
lib/components/audio/UploadAudioStatus - Success-400x200-fr
actual-img
lib/components/audio/UploadAudioStatus - Success-400x200-sw
actual-img
lib/components/audio/UploadAudioStatus - Success-400x200-ms
actual-img
lib/components/audio/UploadAudioStatus - Success-400x200-pt
actual-img
lib/components/audio/UploadAudioStatus - Success-400x200-vi
actual-img
lib/components/audio/UploadAudioStatus - Success-400x200-ru
actual-img
lib/components/audio/UploadAudioStatus - Success-400x200-he
actual-img
lib/components/audio/UploadAudioStatus - Success-400x200-hi
actual-img
lib/components/audio/UploadAudioStatus - Success-400x200-bn
actual-img
lib/components/audio/UploadAudioStatus - Success-400x200-zh
actual-img
lib/components/audio/UploadAudioStatus - Uploading-400x200-as
actual-img
lib/components/audio/UploadAudioStatus - Uploading-400x200-id
actual-img
lib/components/audio/UploadAudioStatus - Uploading-400x200-en
actual-img
lib/components/audio/UploadAudioStatus - Uploading-400x200-es
actual-img
lib/components/audio/UploadAudioStatus - Uploading-400x200-fr
actual-img
lib/components/audio/UploadAudioStatus - Uploading-400x200-sw
actual-img
lib/components/audio/UploadAudioStatus - Uploading-400x200-ms
actual-img
lib/components/audio/UploadAudioStatus - Uploading-400x200-pt
actual-img
lib/components/audio/UploadAudioStatus - Uploading-400x200-vi
actual-img
lib/components/audio/UploadAudioStatus - Uploading-400x200-ru
actual-img
lib/components/audio/UploadAudioStatus - Uploading-400x200-he
actual-img
lib/components/audio/UploadAudioStatus - Uploading-400x200-hi
actual-img
lib/components/audio/UploadAudioStatus - Uploading-400x200-bn
actual-img
lib/components/audio/UploadAudioStatus - Uploading-400x200-zh
actual-img
lib/components/image/AddImage - 0-400x200-as
actual-img
lib/components/image/AddImage - 0-400x200-id
actual-img
lib/components/image/AddImage - 0-400x200-en
actual-img
lib/components/image/AddImage - 0-400x200-es
actual-img
lib/components/image/AddImage - 0-400x200-fr
actual-img
lib/components/image/AddImage - 0-400x200-sw
actual-img
lib/components/image/AddImage - 0-400x200-ms
actual-img
lib/components/image/AddImage - 0-400x200-pt
actual-img
lib/components/image/AddImage - 0-400x200-vi
actual-img
lib/components/image/AddImage - 0-400x200-ru
actual-img
lib/components/image/AddImage - 0-400x200-he
actual-img
lib/components/image/AddImage - 0-400x200-hi
actual-img
lib/components/image/AddImage - 0-400x200-bn
actual-img
lib/components/image/AddImage - 0-400x200-zh
actual-img
routes/[dictionaryId]/contributors/Partners - only_admin_without_Living_Tongues_logo-600x500-en
actual-img expected-img diff-img
routes/[dictionaryId]/contributors/Partners - can_edit-600x500-en
actual-img expected-img diff-img
routes/[dictionaryId]/contributors/Partners - only_admin-600x500-en
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-800x150-id
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-300x150-as
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-800x150-sw
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-800x150-as
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-300x150-he
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-300x150-vi
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-300x150-vi
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-300x150-bn
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-300x150-fr
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-800x150-id
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-300x150-fr
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-300x150-en
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-800x150-ru
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-800x150-es
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-800x150-en
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-800x150-ru
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-300x150-pt
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-800x150-pt
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-800x150-he
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-800x150-fr
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-300x150-hi
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-800x150-vi
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-800x150-zh
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-800x150-en
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-300x150-zh
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-300x150-ru
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-300x150-ru
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-300x150-ms
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-800x150-ms
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-800x150-hi
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-300x150-sw
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-300x150-sw
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-300x150-es
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-300x150-as
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-300x150-es
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-800x150-as
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-800x150-vi
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-300x150-id
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-800x150-es
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-800x150-bn
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-300x150-pt
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-800x150-fr
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-800x150-pt
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-300x150-id
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-300x150-en
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_big_amount_of_data_vs_entry_with_small_amount-800x150-sw
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-300x150-ms
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-300x150-he
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-300x150-hi
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-300x150-bn
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-300x150-zh
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-800x150-ms
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-800x150-he
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-800x150-hi
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-800x150-bn
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/List - entry_with_audio_vs_entry_without_audio-800x150-zh
actual-img expected-img diff-img
routes/[dictionaryId]/entries/list/ListEntry - video_access-400x100-en
actual-img expected-img diff-img
routes/[dictionaryId]/entry/[entryId]/EntryDisplay - Scientific_Name___Partial_italics-Desktop-en
actual-img expected-img diff-img
routes/[dictionaryId]/entry/[entryId]/EntryDisplay - Scientific_Name___Partial_italics-Mobile-en
actual-img expected-img diff-img
routes/[dictionaryId]/entry/[entryId]/EntryDisplay - No_details__can_edit-Desktop-en
actual-img expected-img diff-img
routes/[dictionaryId]/entry/[entryId]/EntryDisplay - No_details__can_edit-Mobile-en
actual-img expected-img diff-img
routes/[dictionaryId]/entry/[entryId]/EntryMedia - 0-400x500-as
actual-img
routes/[dictionaryId]/entry/[entryId]/EntryMedia - 0-400x500-id
actual-img
routes/[dictionaryId]/entry/[entryId]/EntryMedia - 0-400x500-en
actual-img
routes/[dictionaryId]/entry/[entryId]/EntryMedia - 0-400x500-es
actual-img
routes/[dictionaryId]/entry/[entryId]/EntryMedia - 0-400x500-fr
actual-img
routes/[dictionaryId]/entry/[entryId]/EntryMedia - 0-400x500-sw
actual-img
routes/[dictionaryId]/entry/[entryId]/EntryMedia - 0-400x500-ms
actual-img
routes/[dictionaryId]/entry/[entryId]/EntryMedia - 0-400x500-pt
actual-img
routes/[dictionaryId]/entry/[entryId]/EntryMedia - 0-400x500-vi
actual-img
routes/[dictionaryId]/entry/[entryId]/EntryMedia - 0-400x500-ru
actual-img
routes/[dictionaryId]/entry/[entryId]/EntryMedia - 0-400x500-he
actual-img
routes/[dictionaryId]/entry/[entryId]/EntryMedia - 0-400x500-hi
actual-img
routes/[dictionaryId]/entry/[entryId]/EntryMedia - 0-400x500-bn
actual-img
routes/[dictionaryId]/entry/[entryId]/EntryMedia - 0-400x500-zh
actual-img
routes/[dictionaryId]/settings/+page - 0-600x800-as
actual-img
routes/[dictionaryId]/settings/+page - 0-600x800-id
actual-img
routes/[dictionaryId]/settings/+page - 0-600x800-en
actual-img
routes/[dictionaryId]/settings/+page - 0-600x800-es
actual-img
routes/[dictionaryId]/settings/+page - 0-600x800-fr
actual-img
routes/[dictionaryId]/settings/+page - 0-600x800-sw
actual-img
routes/[dictionaryId]/settings/+page - 0-600x800-ms
actual-img
routes/[dictionaryId]/settings/+page - 0-600x800-pt
actual-img
routes/[dictionaryId]/settings/+page - 0-600x800-vi
actual-img
routes/[dictionaryId]/settings/+page - 0-600x800-ru
actual-img
routes/[dictionaryId]/settings/+page - 0-600x800-he
actual-img
routes/[dictionaryId]/settings/+page - 0-600x800-hi
actual-img
routes/[dictionaryId]/settings/+page - 0-600x800-bn
actual-img
routes/[dictionaryId]/settings/+page - 0-600x800-zh
actual-img

View detailed Playwright Report

Copy link

⚡️Lighthouse report

Results for https://living-dictionaries-2if1ezarf-polylingual-development.vercel.app/ (see detailed report)

Category Score
🔴 Performance 35
🟢 Accessibility 90
🟢 Best practices 100
🟢 SEO 96
🟢 PWA 90

Results for https://living-dictionaries-2if1ezarf-polylingual-development.vercel.app/achi/entries/list (see detailed report)

Category Score
🟠 Performance 50
🟠 Accessibility 88
🟢 Best practices 100
🟢 SEO 97
🟢 PWA 90

Results for https://living-dictionaries-2if1ezarf-polylingual-development.vercel.app/jaRhn6MAZim4Blvr1iEv/entry/yt9ja7ymh9xgba5i (see detailed report)

Category Score
🟠 Performance 69
🟠 Accessibility 89
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 90

@livingtongues livingtongues merged commit bda7dea into main Apr 25, 2024
8 checks passed
@livingtongues livingtongues deleted the rest-of-db-operations-through-page-load branch April 25, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants