Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR][CIRGen][Builtin][Neon] Lower neon_vqdmlal, neon_vqdmlsl #1104

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

ghehg
Copy link
Collaborator

@ghehg ghehg commented Nov 11, 2024

No description provided.

@ghehg ghehg marked this pull request as ready for review November 11, 2024 17:43
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you took the opportunity to clean up whitespaces in the other PR, why didn't it fix all of it? A bit odd to see even more in this one - since they are all unrelated to the changes anyways.

@bcardosolopes
Copy link
Member

Please make this PR only do relevant changes, explanations on how to proceed with NFC changes already given recently.

@ghehg
Copy link
Collaborator Author

ghehg commented Nov 11, 2024

Please make this PR only do relevant changes, explanations on how to proceed with NFC changes already given recently.

will revert unrelated formatting changes as I probably accidentally formatted the whole file. Will have another NFC PR to address this problem.

@ghehg ghehg reopened this Nov 12, 2024
@bcardosolopes bcardosolopes merged commit a6c9820 into llvm:main Nov 13, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants