Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc++] Also build the Android Docker image in the workflow #116484

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions .github/workflows/libcxx-build-containers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,11 @@ jobs:
env:
TAG: ${{ github.sha }}

# - name: Build the Android builder image
# working-directory: libcxx/utils/ci
# run: docker compose build android-buildkite-builder
# env:
# TAG: ${{ github.sha }}
- name: Build the Android builder image
working-directory: libcxx/utils/ci
run: docker compose build android-buildkite-builder
env:
TAG: ${{ github.sha }}

- name: Log in to GitHub Container Registry
uses: docker/login-action@v3
Expand All @@ -62,10 +62,10 @@ jobs:
env:
TAG: ${{ github.sha }}

# - name: Push the Android builder image
# if: github.event_name == 'push'
# working-directory: libcxx/utils/ci
# run: |
# docker compose push android-buildkite-builder
# env:
# TAG: ${{ github.sha }}
- name: Push the Android builder image
if: github.event_name == 'push'
working-directory: libcxx/utils/ci
run: |
docker compose push android-buildkite-builder
env:
TAG: ${{ github.sha }}
Loading