Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc++] Silence CMake's install messages in the CI #128872

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

philnik777
Copy link
Contributor

Currently, there are a ton of -- Installing: and -- Up-to-date: messages in the CI log, which just clutter the output. This disables these messages to significantly shorten the CI logs, making them much faster to load and easier to read.

@philnik777 philnik777 marked this pull request as ready for review February 26, 2025 13:14
@philnik777 philnik777 requested a review from a team as a code owner February 26, 2025 13:14
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Feb 26, 2025
@llvmbot
Copy link
Member

llvmbot commented Feb 26, 2025

@llvm/pr-subscribers-libcxx

Author: Nikolas Klauser (philnik777)

Changes

Currently, there are a ton of -- Installing: and -- Up-to-date: messages in the CI log, which just clutter the output. This disables these messages to significantly shorten the CI logs, making them much faster to load and easier to read.


Full diff: https://github.com/llvm/llvm-project/pull/128872.diff

1 Files Affected:

  • (modified) libcxx/utils/ci/run-buildbot (+1)
diff --git a/libcxx/utils/ci/run-buildbot b/libcxx/utils/ci/run-buildbot
index 0ee5bf3e71f59..8a0d4557b56b2 100755
--- a/libcxx/utils/ci/run-buildbot
+++ b/libcxx/utils/ci/run-buildbot
@@ -136,6 +136,7 @@ function generate-cmake-base() {
           -DLIBCXX_ENABLE_WERROR=YES \
           -DLIBCXXABI_ENABLE_WERROR=YES \
           -DLIBUNWIND_ENABLE_WERROR=YES \
+          -DCMAKE_INSTALL_MESSAGE=NEVER \
           -DLLVM_LIT_ARGS="-sv --xunit-xml-output test-results.xml --timeout=1500 --time-tests" \
           "${@}"
 }

Copy link
Member

@ldionne ldionne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ comment added.

@philnik777 philnik777 force-pushed the silence_install_messages branch from 115a689 to c5a993c Compare February 27, 2025 21:56
@philnik777 philnik777 merged commit 28851ed into llvm:main Feb 27, 2025
12 of 16 checks passed
@philnik777 philnik777 deleted the silence_install_messages branch February 27, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants