Add ability to delete traces #314
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to b59910e in 1 minute and 21 seconds
More details
- Looked at
126lines of code in3files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_Wqk9qcu35d8Dhm41
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -20,3 +23,28 @@ export async function GET( | |||
| } | |||
| }); | |||
| } | |||
|
|
|||
| export async function DELETE( | |||
There was a problem hiding this comment.
Consider adding authorization checks to ensure that the user has permission to delete the trace. This will prevent unauthorized deletions.
There was a problem hiding this comment.
This is handled in the middleware
| <Button | ||
| onClick={() => { | ||
| onDelete(traceId, projectId); | ||
| }} | ||
| > | ||
| Delete Trace | ||
| </Button> |
There was a problem hiding this comment.
We probably don't need the separate button in the trace view. I was rather thinking to implement a small overlay in the datatable view, similar to what we have in evaluations, evaluation, datasets, and dataset.
There was a problem hiding this comment.
Speaking of which, it would be great if you could factor out https://github.com/lmnr-ai/lmnr/blob/main/frontend/components/dataset/dataset.tsx#L220-L246 into a separate component, components/ui/DeleteSelectedRows.tsx e.g., and re-use it across the aforementioned components and both the traces and spans tables
| <DeleteSelectedRows | ||
| selectedRowIds={selectedRowIds} | ||
| onDelete={handleDeleteEvaluations} | ||
| entityName="Evaluations" |
There was a problem hiding this comment.
nit. Names must start with lowercase here and elsewhere
nidhi-wa
force-pushed
the
delete_trace
branch
from
c6a279c to
93d9ef3
Compare
|
Thank you ! I truly appreciate your time and effort |
This PR add a functionality of deleting an individual trace.
#282
Important
Add functionality to delete traces with a DELETE API endpoint and UI updates for trace deletion.
DELETEmethod inroute.tsto handle trace deletion from the database.TraceViewcomponent intrace-view.tsx.handleDeleteTracefunction intraces.tsxto call DELETE API and update UI.This description was created by
for b59910e. It will automatically update as commits are pushed.