Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next15 (#279) #315

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Next15 (#279) #315

merged 1 commit into from
Jan 12, 2025

Conversation

dinmukhamedm
Copy link
Member

@dinmukhamedm dinmukhamedm commented Jan 12, 2025

  • first upgrade to next 15

  • fix posthog issue - question in https://posthog.com/docs/libraries/next-js

  • update pnpm lock

  • codemod for async params https://nextjs.org/docs/messages/sync-dynamic-apis#possible-ways-to-fix-it

  • add a setting to remove Yjs dual import warning

  • remove 'view'

  • fix build, mostly by removing unused params in pages

  • fix build again: downgrade react-day-picker

  • pnpm update to fix some peerdeps

  • some more updates to deps

  • further pnpm update

  • update react-day-picker with a few quick styling hacks

  • fix build: react day picker v9

  • restore deleted route, fix avatar on localhost


Important

Upgrade to Next.js 15 with async parameter handling, dependency updates, and build fixes.

  • Upgrade:
    • Upgrade to Next.js 15.
    • Update pnpm lock file.
    • Downgrade react-day-picker to fix build issues.
  • Code Changes:
    • Modify async parameter handling in multiple route.ts files to use props: { params: Promise<...> }.
    • Add setting to remove Yjs dual import warning in next.config.js.
    • Restore deleted route and fix avatar display on localhost.
  • Dependencies:
    • Update various dependencies in package.json, including @aws-sdk/client-s3, @supabase/supabase-js, and react-day-picker.
    • Remove use-enter-submit.tsx hook.
  • Miscellaneous:
    • Minor styling and component adjustments in pipeline-bottom-panel.tsx and calendar.tsx.
    • Fix typo in README.md.

This description was created by Ellipsis for 55767df. It will automatically update as commits are pushed.

* first upgrade to next 15

* fix posthog issue - question in https://posthog.com/docs/libraries/next-js

* update pnpm lock

* codemod for async params https://nextjs.org/docs/messages/sync-dynamic-apis#possible-ways-to-fix-it

* add a setting to remove Yjs dual import warning

* remove 'view'

* fix build, mostly by removing unused params in pages

* fix build again: downgrade react-day-picker

* pnpm update to fix some peerdeps

* some more updates to deps

* further pnpm update

* update react-day-picker with a few quick styling hacks

* fix build: react day picker v9

* restore deleted route, fix avatar on localhost
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 55767df in 1 minute and 51 seconds

More details
  • Looked at 2400 lines of code in 94 files
  • Skipped 1 files when reviewing.
  • Skipped posting 8 drafted comments based on config settings.
1. frontend/app/api/projects/[projectId]/traces/[traceId]/route.ts:8
  • Draft comment:
    The use of Promise for params in the function signature is unnecessary. You can directly destructure params without wrapping it in a Promise. This pattern is repeated across multiple files.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    This is a Next.js API route handler, and in Next.js 13+, route handlers can receive params as a Promise. The change actually makes the code MORE correct by properly handling the Promise nature of params. The comment is suggesting to revert to the old, incorrect way.
    Maybe there's a way to handle the params Promise differently that would be more idiomatic in Next.js? Maybe I'm not familiar with the latest Next.js best practices?
    No, this is a well-documented Next.js 13+ behavior where route params can be Promises and must be awaited. The change is following the correct pattern.
    The comment should be deleted because it's suggesting to remove a necessary Promise wrapper that is actually the correct pattern for Next.js route handlers.
2. frontend/app/api/projects/[projectId]/traces/workshop/[pipelineVersionId]/route.ts:8
  • Draft comment:
    The use of Promise for params in the function signature is unnecessary. You can directly destructure params without wrapping it in a Promise. This pattern is repeated across multiple files.
  • Reason this comment was not posted:
    Marked as duplicate.
3. frontend/app/api/workspaces/[workspaceId]/invite/route.ts:11
  • Draft comment:
    The use of Promise for params in the function signature is unnecessary. You can directly destructure params without wrapping it in a Promise. This pattern is repeated across multiple files.
  • Reason this comment was not posted:
    Marked as duplicate.
4. frontend/app/api/workspaces/[workspaceId]/route.ts:6
  • Draft comment:
    The use of Promise for params in the function signature is unnecessary. You can directly destructure params without wrapping it in a Promise. This pattern is repeated across multiple files.
  • Reason this comment was not posted:
    Marked as duplicate.
5. frontend/app/api/workspaces/[workspaceId]/update-seats/route.ts:11
  • Draft comment:
    The use of Promise for params in the function signature is unnecessary. You can directly destructure params without wrapping it in a Promise. This pattern is repeated across multiple files.
  • Reason this comment was not posted:
    Marked as duplicate.
6. frontend/app/blog/[slug]/page.tsx:14
  • Draft comment:
    The use of Promise for params in the function signature is unnecessary. You can directly destructure params without wrapping it in a Promise. This pattern is repeated across multiple files.
  • Reason this comment was not posted:
    Marked as duplicate.
7. frontend/app/checkout/page.tsx:10
  • Draft comment:
    The use of Promise for searchParams in the function signature is unnecessary. You can directly destructure searchParams without wrapping it in a Promise. This pattern is repeated across multiple files.
  • Reason this comment was not posted:
    Marked as duplicate.
8. frontend/app/checkout/portal/page.tsx:10
  • Draft comment:
    The use of Promise for searchParams in the function signature is unnecessary. You can directly destructure searchParams without wrapping it in a Promise. This pattern is repeated across multiple files.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_Nz4Ef0G2bYdy8VzJ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@dinmukhamedm dinmukhamedm merged commit 8493798 into main Jan 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant