Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cargo-run-bin instead of pinned stellar version #139

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

BlaineHeffron
Copy link
Contributor

Uses cargo-run-bin crate instead of relying on a pinned stellar version in the justfile (which we'd have to keep synced with the cargo.toml files)

resolves #68

@BlaineHeffron
Copy link
Contributor Author

I ended up having to call a script which I placed in a new directory. Perhaps it should be placed somewhere else / called something different.

@BlaineHeffron BlaineHeffron requested a review from chadoh August 1, 2024 23:10
Copy link
Contributor

@chadoh chadoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR may have gotten somewhat out-of-date since you created it?

Copy link
Contributor

@chadoh chadoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chadoh chadoh enabled auto-merge (squash) September 24, 2024 20:58
@chadoh
Copy link
Contributor

chadoh commented Sep 24, 2024

Set to auto-merge once merge conflicts are resolved

auto-merge was automatically disabled September 24, 2024 21:09

Head branch was modified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use cargo-run-bin, remove soroban-cli install from just setup
3 participants