Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recording ISRC #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add recording ISRC #40

wants to merge 1 commit into from

Conversation

Richard-Degenne
Copy link
Contributor

@Richard-Degenne Richard-Degenne commented Jan 18, 2025 •
edited
Loading

This pull request adds a new property isrcs on the Recording model, and updates the recording binding to parse the attribute from API responses.

recording = MusicBrainz::Recording.find('b9ad642e-b012-41c7-b72a-42cf4911f9ff')
recording.isrcs

# => ["JPB600760301"]

@Richard-Degenne
Copy link
Contributor Author

The CI fails for the same reason as #39.

localhots
localhots approved these changes Jan 19, 2025
View reviewed changes
Copy link
Owner

@localhots localhots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Richard-Degenne
Copy link
Contributor Author

I have rebased on top of master to get the CI fix. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@localhots localhots localhots approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Richard-Degenne @localhots