Increase CI coverage: multi-threading, format check #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wxmerkt -- could you rebase this branch? |
wxmerkt
force-pushed
the
topic/increase-ci-coverage
branch
from
4aa628e to
0a2610b
Compare
cmastalli
approved these changes
Jan 10, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #1025. Will rebase once that PR is merged.
Multi-threading is right now only configured for Clang (which works on GitHub Actions, but fails locally 🤷♂️). We can add/change it to g++ (which works locally). Format checking (C++ only for now) is redundant with gepgitlab, but since it runs reasonably fast it can't hurt to have.
Relates to #1026, #1027