Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move loco-rs crate under loco-rs folder #883

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joshka
Copy link
Contributor

@joshka joshka commented Oct 20, 2024

this cleans up the root and makes it easier to focus on just one crate at a time


This is a PR that's sort of a RFC - I won't be offended if you close it as not interested.
It may be related some ideas in little to #881

this cleans up the root and makes it easier to focus on just one crate at a time
@jondot
Copy link
Contributor

jondot commented Oct 20, 2024

Thanks! this is a nice take actually.
We're going to dedicate 0.12.0 under the theme of "removing, simplifying" (#881)

The idea is that when the project started I've put everything bunched up, so that we can see and in that regards "feel" our deps, it makes rust-analyzer's work a bit heavier, it makes the target folder a big bigger, and it makes shipping a release a bit slower.
So we're now putting things into their natural places to simplify and make things more lightweight and easier.

For example: the macros project, did not take off (we thought giving everything a macro for better DX, but that turned out to be un-Rustful)
The extras project evolve in a different speed, and is more "static", and so should be out of the workspace, but closely tested against Loco versions
And @kaplanelad is now experimenting with unifying loco-cli and loco into a single binary+lib crate, so that we can couple new project generation with its testing, and with current versions of the framework (just like Rails does).

We'll see how the simplification effort goes and definitely want to look at this PR again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants