-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SCSS preprocessor #39
Draft
devenini
wants to merge
6
commits into
main
Choose a base branch
from
feature/remove-scss
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mcaskill
requested changes
Jan 8, 2025
Forgot to mention that it will also fix #18 |
mcaskill
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes SCSS from the project and switches to using Tailwind CSS and PostCSS. All variables are now handled in the Tailwind config, and PostCSS plugins are used to cover SCSS-like features such as nesting and custom needs. SCSS was also blocking some Tailwind features from being used, so this change makes the setup simpler and more effective.
Another reason for this change is that SCSS keeps updating and deprecating features, which adds extra work to maintain. Since we don’t really need SCSS anymore, removing it makes the project easier to manage.
Changes
Benefits
For more details on our PostCSS setup, check out the Front-End Helpers repository.