Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQLite parser for Android App Launch (SimpleStorage) file #4930

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

BeefRa
Copy link

@BeefRa BeefRa commented Dec 2, 2024

Add prediction-related fields to Android App Launch parser

  • Updated the Android App Launch parser to include additional fields:
    • prediction_ui_surface_id
    • prediction_source_id
    • prediction_rank

These fields are extracted from the 'EchoAppLaunchMetricsEvents' table and stored in event_data.
This enhancement allows better tracking of app launch predictions.

Notes:

All contributions to Plaso undergo code review.
This makes sure that the code has appropriate test coverage and conforms to the
Plaso style guide.

One of the maintainers will examine your code, and may request changes. Check off the items below in
order, and then a maintainer will review your code.

Checklist:

  • Automated checks (GitHub Actions, AppVeyor) pass
  • No new new dependencies are required or l2tdevtools has been updated
  • Reviewer assigned
  • Test data has a Plaso compatible license

@joachimmetz
Copy link
Member

Thanks for the PR, I'm a bit preoccupied at the moment will try to take a look as soon as time permits

@BeefRa BeefRa changed the title Add prediction-related fields to Android App Launch Parser Add SQLite parser for Android App Launch (SimpleStorage) file Dec 9, 2024
@joachimmetz joachimmetz self-assigned this Mar 2, 2025
@joachimmetz
Copy link
Member

joachimmetz commented Mar 2, 2025

@BeefRa couple of questions:

  • I assume log2timeline-20241202T054857.log.gz was added by accident and is not intended to be part of the PR
  • what is the origin of the test data file?
  • PTAL at the linter warnings

Also for future PRs please don't remove the check list as part of the boiler plate PR message

@joachimmetz joachimmetz added the pending reporter input Issue is pending input from the reporter label Mar 2, 2025
@joachimmetz
Copy link
Member

Rebased PR

Copy link

codecov bot commented Mar 2, 2025

Codecov Report

Attention: Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.10%. Comparing base (11259d3) to head (02d1985).

Files with missing lines Patch % Lines
plaso/parsers/sqlite_plugins/android_app_launch.py 97.36% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4930      +/-   ##
==========================================
+ Coverage   85.09%   85.10%   +0.01%     
==========================================
  Files         432      433       +1     
  Lines       38792    38830      +38     
==========================================
+ Hits        33009    33046      +37     
- Misses       5783     5784       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending reporter input Issue is pending input from the reporter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants