Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Handle parachain prefix #28

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Handle parachain prefix #28

merged 2 commits into from
Apr 11, 2024

Conversation

gdethier
Copy link
Contributor

@gdethier gdethier commented Apr 9, 2024

  • Use ValidAccountId in model.
  • Store with Substrate format (prefix 42).
  • Expose (through REST API) with Logion format (prefix 2021).
  • Fixes integration tests (DB migrations).

logion-network/logion-internal#1216

@gdethier gdethier requested a review from benoitdevos April 9, 2024 09:47
benoitdevos
benoitdevos approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@benoitdevos benoitdevos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/logion/model/legalofficer.model.ts Outdated Show resolved Hide resolved
@gdethier gdethier merged commit 1d74207 into main Apr 11, 2024
1 check passed
@gdethier gdethier deleted the feature/logion-prefix branch April 11, 2024 11:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benoitdevos benoitdevos benoitdevos approved these changes

Assignees

@gdethier gdethier

@benoitdevos benoitdevos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdethier @benoitdevos