Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create LogionClient from Environment. #547

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Create LogionClient from Environment. #547

merged 2 commits into from
Mar 14, 2024

Conversation

benoitdevos
Copy link
Contributor

@benoitdevos benoitdevos commented Mar 13, 2024 •
edited
Loading

  • The front can be configured from an environment (currently, DEV, TEST or MVP) - a sample is provided.
  • Property edgeNodes is replaced with rpcEndpoints.
  • The following properties are then obtained from the environment and do not require to be explicitly given: directory, rpcEndpoints, logionClassification and creativeCommons.
  • Some clean-up is done: useless RPC, REACT_APP_PROVIDER_SOCKET and REACT_APP_DEVELOPMENT_KEYRING properties are removed.

logion-network/logion-internal#1099

@benoitdevos benoitdevos requested a review from gdethier March 13, 2024 12:06
@benoitdevos benoitdevos marked this pull request as ready for review March 13, 2024 16:35
This was referenced Mar 13, 2024
Merged
Merged
gdethier
gdethier approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@gdethier gdethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thanks for the clean-up.

src/loc/ImportItems.tsx Show resolved Hide resolved
@benoitdevos benoitdevos merged commit f179241 into main Mar 14, 2024
1 check passed
@benoitdevos benoitdevos deleted the feature/use-env branch March 14, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdethier gdethier gdethier approved these changes

Assignees

@gdethier gdethier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benoitdevos @gdethier