Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable secret recovery request review #574

Merged
merged 1 commit into from
May 23, 2024
Merged

Enable secret recovery request review #574

merged 1 commit into from
May 23, 2024

Conversation

gdethier
Copy link
Contributor

@gdethier gdethier commented May 22, 2024 •
edited
Loading

logion-network/logion-internal#1264

@gdethier gdethier requested a review from benoitdevos May 22, 2024 08:13
benoitdevos
benoitdevos reviewed May 22, 2024
View reviewed changes
Copy link
Contributor

@benoitdevos benoitdevos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gdethier gdethier force-pushed the feature/review-secret-recovery branch from 7504c82 to 35081a8 Compare May 23, 2024 10:52
@gdethier gdethier force-pushed the feature/review-secret-recovery branch from 35081a8 to f10482f Compare May 23, 2024 11:00
@gdethier gdethier marked this pull request as ready for review May 23, 2024 11:01
@gdethier gdethier requested a review from benoitdevos May 23, 2024 11:06
benoitdevos
benoitdevos approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@benoitdevos benoitdevos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !

@gdethier gdethier merged commit d611b94 into main May 23, 2024
1 check passed
@gdethier gdethier deleted the feature/review-secret-recovery branch May 23, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitdevos benoitdevos benoitdevos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdethier @benoitdevos