Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): multiplatform build #524

Merged

Conversation

COLDTURNIP
Copy link
Contributor

Multiplatform build support on CI workflow.

@COLDTURNIP COLDTURNIP requested a review from derekbit February 14, 2025 03:34
Copy link

coderabbitai bot commented Feb 14, 2025

Walkthrough

This pull request introduces two changes. First, a new environment variable TARGET_PLATFORMS with the value linux/amd64,linux/arm64 is added to the build_push_image job in the GitHub Actions workflow to specify target platforms for Docker image builds. Second, a Bash script is updated to use mkdir -p ./bin instead of mkdir ./bin || true to simplify and robustify directory creation.

Changes

File(s) Change Summary
.github/workflows/build.yml Added a new environment variable TARGET_PLATFORMS (set to linux/amd64,linux/arm64) in the build_push_image job.
scripts/package Modified the directory creation command from `mkdir ./bin

Possibly related PRs

Suggested reviewers

  • innobead
  • FrankYang0529
  • c3y1huang
  • derekbit
  • shuo-wu

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6c5fcd6 and 6af518f.

📒 Files selected for processing (2)
  • .github/workflows/build.yml (1 hunks)
  • scripts/package (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: commit-lint
  • GitHub Check: Build binaries
  • GitHub Check: Summary
🔇 Additional comments (2)
scripts/package (1)

62-62: LGTM! Improved directory creation command.

The change from mkdir ./bin || true to mkdir -p ./bin is a more idiomatic approach. The -p flag ensures that:

  1. No error is raised if the directory already exists
  2. Parent directories are created if they don't exist

This change improves the robustness of the build process.

.github/workflows/build.yml (1)

85-85: LGTM! Added multi-platform build support.

The addition of TARGET_PLATFORMS environment variable with linux/amd64,linux/arm64 enables building Docker images for both AMD64 and ARM64 architectures. This change:

  1. Enhances the CI workflow with multi-platform support
  2. Works seamlessly with the updated package script
  3. Targets the most common server architectures

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@COLDTURNIP COLDTURNIP changed the title fix multiplatform build fix(ci): multiplatform build Feb 14, 2025
@derekbit derekbit merged commit 4555c06 into longhorn:master Feb 14, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants