Skip to content

Commit

Permalink
fix(ci): fix binary dependency for local build
Browse files Browse the repository at this point in the history
Signed-off-by: Raphanus Lo <[email protected]>
  • Loading branch information
COLDTURNIP authored and derekbit committed Feb 17, 2025
1 parent 5de8211 commit 6adfef8
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 12 deletions.
8 changes: 0 additions & 8 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,6 @@ jobs:
run: |
chmod +x ./bin/*
- name: Copy bin folder to package
run: |
cp -r ./bin ./package/
- name: Login to Docker Hub
uses: docker/login-action@v3
with:
Expand Down Expand Up @@ -166,10 +162,6 @@ jobs:
run: |
chmod +x ./bin/*
- name: Copy bin folder to package
run: |
cp -r ./bin ./package/
- name: Login to Docker Hub
uses: docker/login-action@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion package/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ COPY --from=cbuilder \

RUN ldconfig

COPY package/bin/longhorn-instance-manager /usr/local/bin/
COPY bin/longhorn-instance-manager /usr/local/bin/
COPY package/instance-manager /usr/local/bin/
COPY package/instance-manager-v2-prestop /usr/local/bin/

Expand Down
6 changes: 3 additions & 3 deletions scripts/package
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ IID_FILE_FLAG=${IID_FILE_FLAG:-''}
SRC_BRANCH=${SRC_BRANCH:-''}
SRC_TAG=${SRC_TAG:-''}

# TODO: implement self-contained build
[[ ! -x ./bin/longhorn-instance-manager ]] && ./scripts/build

if [[ -z $TAG ]]; then
if API_VERSION=$(./bin/longhorn-instance-manager version --client-only | jq ".clientVersion.instanceManagerAPIVersion"); then
TAG="v${API_VERSION}_$(date -u +%Y%m%d)"
Expand Down Expand Up @@ -59,9 +62,6 @@ else
x86_64)
ARCH=amd64
;;
s390x)
ARCH=s390x
;;
*)
echo "$(uname -a): unsupported architecture"
exit 1
Expand Down

0 comments on commit 6adfef8

Please sign in to comment.