test(integration): support v2 volume test on test_ha.py

[chriscchien]

Which issue(s) this PR fixes:

Issue #9760

What this PR does / why we need it:

support v2 volume test on test_ha.py

Special notes for your reviewer:

Test result

• test_rebuild_with_restoration falky

Additional documentation or context

Summary by CodeRabbit

• Tests
  • Enhanced integration tests to validate volume operations across backup, recovery, and expansion scenarios.
  • Improved test categorization with the addition of a new version marker for better organization and execution of tests.
  • Introduced conditional logic for snapshot deletion based on data engine version.
  • Added new parameter for data engine in volume creation calls to ensure proper functionality.

[coderabbitai]

Walkthrough

This change updates the integration test file to incorporate the DATA_ENGINE constant. It modifies multiple test functions by adding the dataEngine parameter to volume creation calls and wrapping volume operation logic with conditional checks based on the data engine version. In addition, tests are now marked with the @pytest.mark.v2_volume_test decorator to categorize them under the new versioning scheme.

Changes

File(s)	Summary
manager/integration/tests/test_ha.py	- Imported the DATA_ENGINE constant from the common module. - Added the dataEngine parameter to various volume creation calls. - Introduced conditional logic in snapshot deletion and volume expansion based on DATA_ENGINE. - Applied @pytest.mark.v2_volume_test to multiple test functions.

Possibly related PRs

• test(integration): test_rwx.py support v2 volume #2201: The changes in the main PR and this PR are related as both introduce the DATA_ENGINE constant and the @pytest.mark.v2_volume_test decorator to their respective test files, affecting similar volume creation and manipulation functionalities.
• test(integration): support v2 volume test on test_kubernetes.py #2307: The changes in the main PR are related to those in this PR as both involve the integration of the DATA_ENGINE constant and the addition of the dataEngine parameter in volume creation calls within their respective test files.
• test(integration): support v2 volume test in test_node.py #2311: The changes in the main PR are related to those in this PR as both involve the integration of the dataEngine parameter in volume creation calls and the use of the @pytest.mark.v2_volume_test decorator for categorizing tests under the v2 volume management framework.

Suggested reviewers

• yangchiu

Poem

I'm a rabbit hopping through code so bright,
Adding DATA_ENGINE to tests with delight.
With each decorator and function in sight,
I nibble bugs 'til they take flight.
Cheers to version two, our code takes a leap! 🐇

🥕 Happy coding, from my burrow to your screen!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e2f1924 and 2d653e3.

📒 Files selected for processing (1)

• manager/integration/tests/test_ha.py (29 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• manager/integration/tests/test_ha.py

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Build images
• GitHub Check: Summary

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[roger-ryao]

LGTM

[yangchiu]

@mergify backport v1.8.x

[mergify]

backport v1.8.x

✅ Backports have been created

• #2335 test(integration): support v2 volume test on test_ha.py (backport #2321) has been created for branch v1.8.x