feat(lvol): snapshot labels #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamiaSan
requested review from
innobead,
derekbit,
PhanLe1010,
c3y1huang,
shuo-wu and
a team
The addition and the update of external xattrs have been enabled for read only blobs, whose metadata can't change. Longhorn 9808 Signed-off-by: Damiano Cipriani <[email protected]>
The addition and the update of xattrs have been enabled for read only lvols. Longhorn 9808 Signed-off-by: Damiano Cipriani <[email protected]>
Setting xattr is permitted also for snapshots. Longhorn 9808 Signed-off-by: Damiano Cipriani <[email protected]>
DamiaSan
force-pushed
the
snapshot_labels
branch
from
9baa9e6 to
f85a12c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#9808
What this PR does / why we need it:
We need the possibility to add labels into snapshots also for v2 engine, so the setting of xattrs has been enabled also for read only logical volumes.
Special notes for your reviewer:
Additional documentation or context