New frontpage and App theme with functionality showcase #482
Conversation
|
@lonnieezell, this is one where I need your review. The example module, which I placed within the theme for copying on install, might be inappropriately placed. Now I think it could just go into /src/ and stay there as an example module without the copying to app/Modules ... Also I need your assessment if the content of the example page is ok, or if perhaps something should be changed. |
dgvirtual
force-pushed
the
example-app-code
branch
from
b8453c4 to
7f12b1d
Compare
|
I think this is cool from the standpoint of showing people what can be done and how to work with some of the things. To be honest, though, it feels like too much. If I'm installing Bonfire into a new system, I don't want to have to delete all of this every time. I think this would be better as an example repo, which would be pretty cool to have around! |
|
Ok, how about we make a section in documentation 'Extending Bonfire' or sth like that and put there info about supplementery modules. And I will make this into a separate repo. I have another one pages that would be useful as an example. |
dgvirtual
force-pushed
the
example-app-code
branch
from
7f12b1d to
8018356
Compare
|
I have made a separate repo with this code bonfire2-frontpage-theme. I have also updated documentation to refer to the external modules/themes as we discussed above - see PR #551. Therefore I am closing this PR. |
I have played around the enhancements of the App theme and made a simple new default page. Got carried away and created even a logo for Bonfire2 (developer art, but still...).
You can see it showcased here: https://bonfire2.lapas.info/ (@lonnieezell can also login as superadmin using his gmail address and magic link).
I have made the installation as simple as possible. But not sure if it showcases the best practices, so some review might be in order.
If this works, after review and implementation of suggestions I will also update documentation.
This should close #453