Fix controlled component class name guessing, fix processing of self-closing component attributes #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgvirtual
changed the title
dgvirtual
force-pushed
the
fix/controlled_component
branch
from
73771a1 to
aa3464e
Compare
dgvirtual
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
component-name.phpfile names were not properly pascalized when guessing the controlled component class names (sincepascalize()does not actually affect dashes, only spaces and underscores). Therefore this fix. Example app code at PR #482 depends on this fix, as it now includes an example controlled component.