heart rate, cadence, temperature, speed, and power #17
Conversation
Bumps [flask](https://github.com/pallets/flask) from 1.1.2 to 2.3.2. - [Release notes](https://github.com/pallets/flask/releases) - [Changelog](https://github.com/pallets/flask/blob/main/CHANGES.rst) - [Commits](pallets/flask@1.1.2...2.3.2) --- updated-dependencies: - dependency-name: flask dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [requests](https://github.com/psf/requests) from 2.23.0 to 2.31.0. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.23.0...v2.31.0) --- updated-dependencies: - dependency-name: requests dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
…peed, power, as available.
|
Thank you very much! I'll have a look as soon as I can |
There was a problem hiding this comment.
Last week I had to update this file because for some reason Pip wasn't installing Flask dependencies (the MR doesn't contain these changes, it needs to be rebased), so I had to explicitly list them here (see #16). I'm wondering whether we need to update these dependencies or if we can just remove them (assuming that when installing flask 2.3.2 Pip will automatically pull jinja2, werkzeug and itsdangerous)
There was a problem hiding this comment.
You are right, I'll rebase this commit.
There was a problem hiding this comment.
Do we need this file? As far as I can see it was used to verify that some code changes were still producing a valid GPX, but I think we can remove it now?
There was a problem hiding this comment.
Hmmm, I will try to make a better unit test system that doesn't depend on the patch file and doesn't depend on pulling data down from the network.
Before I start, though, do you think I should use unittest?
https://docs.python.org/3/library/unittest.html
Or something different?
There was a problem hiding this comment.
In addition to unittest, here are two others mentioned in the docs:
I've never used any of these, but I'll use the one you recommend.
There was a problem hiding this comment.
Probably I misinterpreted the code here: I thought that test.sh was only used to validate code changes (i.e. apply a patch and validate the output against an xsd), that's why I wasn't sure if they belong here. If that's not the case, I see no harm in keeping them.
There was a problem hiding this comment.
Same as the other patch file
There was a problem hiding this comment.
Same as the patch files
It's my yearly pull request!