-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RuboCop #1149
Update RuboCop #1149
Conversation
c751e03
to
d2d52e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a stab at this, we totally needed an update.
I've left some comments/change requests
411e16b
to
b327886
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your awesome work here. It's doing a lot of good!
I had one question, you can find it inline.
Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AlexWayfer for addressing all my comments 😄!
And sorry if I came across as a bit fussy, we really appreciate all the improvements you've added here!
One last request (but not mandatory to merge, I can do it later if you don't have time), since we decided to rename #method
into #http_method
and deprecated the old method, it would be good to update the UPGRADING.md
file as well to keep track of all backwards-incompatible changes.
I think this is going to be the first v2.0 note!
Require its specific version in `Gemfile`. Fix it's installation in CI. Enable new cops. Resolve new offenses. Drop support of Ruby 2.3 (it's not supported by RuboCop and by MRI:https://www.ruby-lang.org/en/news/2019/03/31/support-of-ruby-2-3-has-ended/) Deprecate `Faraday::Request#method`, replace it with `#http_method`.
b327886
to
1bd13da
Compare
No problem.
Thank you, I see. 😉 And thank you for help and discussing.
I agree, added. If you want another content of this note — please, write, it's not too hard for me to change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks for sticking with it. <3
Require its specific version in
Gemfile
.Fix it's installation in CI.
Enable new cops.
Resolve new offenses.
Drop support of Ruby 2.3
(it's not supported by RuboCop and by MRI:https://www.ruby-lang.org/en/news/2019/03/31/support-of-ruby-2-3-has-ended/)
Deprecate
Faraday::Request#method
, replace it with#http_method
.Todos
List any remaining work that needs to be done, i.e:
Additional Notes
It requires for neighbor pull requests.