Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GC9307 panel. #645

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Add GC9307 panel. #645

merged 1 commit into from
Nov 14, 2024

Conversation

lbuque
Copy link
Contributor

@lbuque lbuque commented Nov 13, 2024

Tested the panel successfully using esp32c3.

Snipaste_2024-11-14_01-31-26

But I used esp32c6 to test and some problems occurred. Please refer to #644

@tobozo
Copy link
Collaborator

tobozo commented Nov 13, 2024

hi, thanks for testing this 👍

can you please use the develop branch as source and target for your pull request

you'll probably have to open a new PR and close this one, sorry about that

Signed-off-by: lbuque <[email protected]>
@lbuque lbuque changed the base branch from master to develop November 14, 2024 01:24
@lbuque
Copy link
Contributor Author

lbuque commented Nov 14, 2024

@tobozo I have followed your suggestion and requested PR to be merged into devlop

@tobozo tobozo merged commit 4168ba6 into lovyan03:develop Nov 14, 2024
101 checks passed
@tobozo
Copy link
Collaborator

tobozo commented Nov 14, 2024

thanks!

did this PR also address the ESP32-C6 issue?

@lovyan03
Copy link
Owner

oh no...
image

@lbuque
Adding offsets should be done in the panel settings and not hard coded into the program.
We would like to remove these offsets.

@lbuque
Copy link
Contributor Author

lbuque commented Nov 26, 2024

@lovyan03 Yes, because it is flawed.

@lovyan03
Copy link
Owner

@lbuque
flawed ?
I don't understand what it means.

@lbuque
Copy link
Contributor Author

lbuque commented Nov 27, 2024

@lovyan03 The code I submitted earlier was not perfect.

@lovyan03
Copy link
Owner

@lbuque
Who will do it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants